fix: wheel for windows #111
Conversation
|
Warning! No news item is found for this PR. If this is a user-facing change/feature/fix, |
|
Awesome Tieqiong. Yes, once merged, I will do copy and paste. |
|
@bobleesj Maybe it's better to copy the workflow before this get merged, because I don't want the dummy workflow to be merged. I will delete it after Simon review it and before merge. |
|
👍 understood. Once @sbillinge gives it a quick review, we can try rc7 release of pdffit then? @Tieqiong |
| name: Wheel builder | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
shall we do just pull_request and push into main? I think that is our standard on our other workflows
There was a problem hiding this comment.
@sbillinge I'll delete this workflow file before merging. This is just for showing the changes work here, and it would be easier for @bobleesj to copy to the central release-script. So details shouldn't matter too much.
There was a problem hiding this comment.
@Tieqiong Billingegroup/release-scripts#123
I copied and saved in the issue. pls confirm if that's all good.
There was a problem hiding this comment.
@bobleesj please see comment there
There was a problem hiding this comment.
As a general rule I like taking care of details when we think of them, otherwise technical debt tends to just start piling up. But if this is going to be completely gone through again later and everything fixed, i htink it is ok to let things slide here.
setup.py
Outdated
| class CustomBuildExt(build_ext): | ||
| def run(self): | ||
| super().run() | ||
| gsl_path = os.environ.get("GSL_PATH") or os.path.join(os.environ.get("CONDA_PREFIX", ""), "Library") |
There was a problem hiding this comment.
I would prefer if we could use pathlib.Path() as much as possible for these operations, for easier future maintainability.
There was a problem hiding this comment.
@sbillinge I changed most of the os.path to pathlib. Please check, thanks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 6 6
Lines 1261 1261
=======================================
Hits 1248 1248
Misses 13 13 |
@sbillinge This should fix diffpy/diffpy.pdfgui#238 and diffpy/diffpy.pdfgui#240 after another pypi release. Before merging this the workflow file still need to be changed. The one attached here is just for showing it works.
@bobleesj Can you help merging this workflow file into the release-script central workflow? Thanks!
These are the local test of the wheel produced here
Windows with python3.12:
Linux with python3.12:
Mac Arm with python3.12:
